allow a local .env file to override compose.yaml sibling .env #11824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
glours,
milas and
jhrotko
and removed request for
a team
ndeloof
force-pushed
the
dotEnvStrikesBack
branch
from
1873276
to
16622fc
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
dotEnvStrikesBack
branch
from
16622fc
to
38e42a4
Compare
Did you change the documentation to make it more clear? I remember you have mentioned it before just asking the current status |
|
@jhrotko I'll do once this PR is merged |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allow local .env file both to set COMPOSE_* variables and override .env file aside the target compose.yaml file
This restores behavior seen in compose v2 before v2.24.x, while undocumented. Was initially introduced by #9512 while not designed for this usage, but users started then to rely on this "feature"
A doc PR will follow so this is well documented
Related issue
fixes #11823
fixes #11575
https://docker.atlassian.net/browse/COMP-570
(not mandatory) A picture of a cute animal, if possible in relation to what you did